[PATCH] D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/Object/ELF.h:469
     return "";
+  // TODO: A case when SHN_XINDEX is broken isn't tested.
   if (Index >= Sections.size())
----------------
It's not SHN_XINDEX that's broken (it can't be - "SHN_XINDEX" is just an enum value), it's the sh_link of the section with index 0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64714/new/

https://reviews.llvm.org/D64714