[PATCH] D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 02:30:22 PDT 2019


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:775
+    Value *V1 = SimplifyFPBinOp(Opcode, C, F, FMF, SQ.getWithInstruction(&I));
+    Value *V2 = SimplifyFPBinOp(Opcode, B, E, FMF, SQ.getWithInstruction(&I));
     if (V1 && V2)
----------------
Question to reviewers: would it be better to enhance SimplifyQuery / InstrInfoQuery to know about fast math flags, so that I don't have to pass FMF around explicitly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64713/new/

https://reviews.llvm.org/D64713





More information about the llvm-commits mailing list