[PATCH] D60351: [builtins] Reformat builtins with clang-format

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 14:48:02 PDT 2019


Thanks!

On Fri, Jul 12, 2019 at 2:15 PM Nikita Popov via Phabricator
<reviews at reviews.llvm.org> wrote:
>
> nikic added inline comments.
>
>
> ================
> Comment at: compiler-rt/trunk/lib/builtins/arm/sync-ops.h:37
> +  DEFINE_COMPILERRT_THUMB_FUNCTION(__sync_fetch_and_##op)                      \
> +  push{r4, r5, r6, lr};                                                        \
> +  dmb;                                                                         \
> ----------------
> nikic wrote:
> > It looks like this reformatted to illegal assembly:
> >
> > ```
> > compiler-rt/lib/builtins/arm/sync_fetch_and_add_8.S:21: Error: bad instruction `push{r4, r5,r6,lr}'
> > ```
> >
> > The whitespace between `push` and `{` likely needs to be preserved.
> I've added back the space in rL365957.
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D60351/new/
>
> https://reviews.llvm.org/D60351
>
>
>


More information about the llvm-commits mailing list