[PATCH] D61259: AArch64: support arm64_32, an ILP32 slice for watchOS.

Alex Denisov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 13 05:55:43 PDT 2019


AlexDenisov added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:430
 
+  bool addrSinkUsingGEPs() const override {
+    // Keeping GEPs inbounds is important for exploiting AArch64
----------------
When I compile LLVM with this patch applied I'm getting the error:

```
AArch64Subtarget.h:430:34: error: only virtual member functions can be marked 'override'
  bool addrSinkUsingGEPs() const override {
                                 ^~~~~~~~~
```
Removing the override keyword fixes it, but I'm curious where it comes from? I cannot see any usage of this method across the code base.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61259/new/

https://reviews.llvm.org/D61259





More information about the llvm-commits mailing list