[PATCH] D64674: [NFC][llvm-readobj] Refactor dynamic string table indexing into a function.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 18:05:53 PDT 2019


MaskRay added a comment.

Do you find another use case of `printDynamicString`? If yes, can you name it?



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:300
+  void printDynamicString(uint64_t Value, raw_ostream &OS,
+                          bool WithBracket = true) const;
 
----------------
Delete ` = true`. The default argument is not used I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64674/new/

https://reviews.llvm.org/D64674





More information about the llvm-commits mailing list