[PATCH] D64665: [MachinePipeliner] Refactor schedule emission logic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 14:04:48 PDT 2019


arsenm added inline comments.


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:3277-3278
+    for (auto &MO : NewMI->defs()) {
+      unsigned OrigReg = MO.getReg();
+      unsigned DestReg = MRI.createVirtualRegister(MRI.getRegClass(OrigReg));
+      NewMI->substituteRegister(OrigReg, DestReg, MO.getSubReg(),
----------------
arsenm wrote:
> Should update to use Register
See r364191. Registers should no longer be plain unsigned


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64665/new/

https://reviews.llvm.org/D64665





More information about the llvm-commits mailing list