[PATCH] D64643: [WebAssembly] refactored utilities to not depend on MachineInstr

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 11:47:12 PDT 2019


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM. How about adding overriden functions that takes `MachineInstr` argument that calls these functions? And if this is pure refactoring adding `(NFC)` to the title might be better.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64643/new/

https://reviews.llvm.org/D64643





More information about the llvm-commits mailing list