[PATCH] D64639: [FileCheck] Store line numbers as optional values

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 08:01:57 PDT 2019


thopre created this revision.
thopre added reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk.
thopre added a project: LLVM.
thopre added a child revision: D60388: FileCheck [8/12]: Define numeric var from expr.
thopre added a parent revision: D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Processing of command-line definition of variable and logic around
implicit not directives both reuse parsing code that expects a line
number to be defined. So far, a special line number of 0 was used for
those users of the parsing code where a line number does not make sense.
This commit instead represents line numbers as Optional values so that
they can be None for those cases.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64639

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64639.209487.patch
Type: text/x-patch
Size: 9536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190712/e93bc670/attachment.bin>


More information about the llvm-commits mailing list