[PATCH] D64633: Slightly simplify MappedBlockStream::createIndexedStream() calls

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: rnk.
Herald added subscribers: arphaman, hiraditya.
Herald added a project: LLVM.

All callers had a PDBFile object at hand, so call Pdb.createIndexedStream() instead, which pre-populates all the arguments (and returns nullptr for kInvalidStreamIndex).

Also change safelyCreateIndexedStream() to only take the string index, and update callers. Make the method public and call it in two places that manually did the bounds checking before.

No intended behavior change.


https://reviews.llvm.org/D64633

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/PDBFile.h
  llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBFile.cpp
  llvm/lib/DebugInfo/PDB/Native/TpiStream.cpp
  llvm/tools/llvm-pdbutil/BytesOutputStyle.cpp
  llvm/tools/llvm-pdbutil/LinePrinter.cpp
  llvm/tools/llvm-pdbutil/YAMLOutputStyle.cpp
  llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64633.209478.patch
Type: text/x-patch
Size: 9886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190712/41f6bdce/attachment.bin>