[llvm] r365897 - [gn] Tag unneeded variable.

Bryant Wong via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 06:09:39 PDT 2019


Author: bryant
Date: Fri Jul 12 06:09:39 2019
New Revision: 365897

URL: http://llvm.org/viewvc/llvm-project?rev=365897&view=rev
Log:
[gn] Tag unneeded variable.

When only building targets without assembly parsers (e.g. `llvm_targets_to_build
= ["NVPTX"]`), `all_targets` is empty and causes GN to warn about an
assigned-but-unused variable.

Differential Revision: https://reviews.llvm.org/D31727

Modified:
    llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn?rev=365897&r1=365896&r2=365897&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn Fri Jul 12 06:09:39 2019
@@ -383,6 +383,9 @@ template("write_target_def_file") {
     foreach(target, all_targets) {
       value = "$value${invoker.value}($target)\n"
     }
+    if (all_targets == []) {
+      not_needed(invoker, [ "value" ])
+    }
     values = [ "${invoker.key}=$value" ]
   }
 }




More information about the llvm-commits mailing list