[PATCH] D64497: [AMDGPU] Allow abs/neg source modifiers on v_cndmask_b32

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D64497#1581712 <https://reviews.llvm.org/D64497#1581712>, @hakzsam wrote:

> This change introduced CTS regressions with RADV like dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.atan2_frag and friends.
>  Can you investigate ?


Yes, sorry, I can reproduce the following failures (with LLPC not RADV):

dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.faceforward_vert
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.faceforward_tessc
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.faceforward_tesse
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.faceforward_geom
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.faceforward_frag
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.faceforward_vert
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.faceforward_tessc
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.faceforward_tesse
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.faceforward_geom
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.faceforward_frag
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.faceforward_vert
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.faceforward_tessc
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.faceforward_tesse
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.faceforward_geom
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.faceforward_frag
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.faceforward_vert
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.faceforward_tessc
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.faceforward_tesse
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.faceforward_geom
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.faceforward_frag

I'll see if I can fix them. Let me know if you want a revert in the mean time.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64497/new/

https://reviews.llvm.org/D64497