[PATCH] D64575: [clangd] Prioritize indexing of files that share a basename with the open file.

Kadir Cetinkaya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 02:56:40 PDT 2019


kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/TUScheduler.h:145
 
-  /// Schedule an update for \p File. Adds \p File to a list of tracked files if
-  /// \p File was not part of it before. The compile command in \p Inputs is
----------------
Is the `Adds \p File to a list of tracked files if ...` part got deleted intentionally?


================
Comment at: clang-tools-extra/clangd/index/Background.h:106
   std::vector<Task> Queue; // max-heap
+  llvm::StringMap<unsigned> Boosts;
 };
----------------
maybe store a `QueuePriority` instead of unsigned? Also it seems like the enum belongs to BackgroundQueue, rather then BackgroundIndex


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64575/new/

https://reviews.llvm.org/D64575





More information about the llvm-commits mailing list