[PATCH] D64297: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 02:24:02 PDT 2019


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

> Using ccache and distcc together is a common pattern.

My preference would be just allow one single compiler launcher, i.e. `distcc ccache gcc` is not allowed. Then

> while (unwrapCommand(Arguments));

becomes

`unwrapCommand(Arguments);`

These commands can be freely used as extensionless header files: `#include <distcc>`. That said, I don't have objection to this approach.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64297/new/

https://reviews.llvm.org/D64297





More information about the llvm-commits mailing list