[PATCH] D64311: WIP: [llvm-objdump] Implement syntax highlighting

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 01:19:02 PDT 2019


seiya marked an inline comment as done.
seiya added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp:42
+void X86ATTInstPrinter::printMarkedUpRegName(raw_ostream &OS, unsigned RegNo) {
+  markupStart(OS, MarkupState, MarkupType::Reg);
+  write(OS, MarkupState, "%");
----------------
I think implementing `operator<<` would be better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64311/new/

https://reviews.llvm.org/D64311





More information about the llvm-commits mailing list