[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 18:05:02 PDT 2019


nickdesaulniers added inline comments.


================
Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:3555
+  // in -E mode either for example, even though it's not really used either.
+  if (!isa<AssembleJobAction>(JA)) {
+    ArgStringList DummyArgs;
----------------
Should you be checking `!TC.IsIntegratedAssemblerDefault()` additionally?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64527/new/

https://reviews.llvm.org/D64527





More information about the llvm-commits mailing list