[PATCH] D64589: [UpdateLLCTestChecks] Emit warning when invalid value for -check-prefix option

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 14:08:20 PDT 2019


lebedev.ri added a comment.

I'm not confident that will do the right thing. (i expect this to have some false-negatives, iff it is allowed to specify `-check-prefix=` more than once)
I see two paths:

1. split the runline by whitespace, and check every element that starts with `-check-prefix=` that it does not contain `,`. Will not have false-positives and no false-negatives, but kinda ugly.
2. Revert to the previous diff, complain if there are any `-check-prefix=` IFF we had more than a single prefix; the warning will need to be changed - it will have false-positives - so it is more of a stylistic guideline.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64589/new/

https://reviews.llvm.org/D64589





More information about the llvm-commits mailing list