[PATCH] D64588: Minor cleanup.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 13:32:56 PDT 2019


tra created this revision.
tra added a reviewer: timshen.
Herald added subscribers: bixia, jlebar.
Herald added a project: LLVM.

Simplify things a bit by removing unnecessary full type qualification.
This also happens to avoid a build break with now-unsupported MSVC 2014.


https://reviews.llvm.org/D64588

Files:
  llvm/include/llvm/Analysis/IteratedDominanceFrontier.h
  llvm/include/llvm/Support/GenericIteratedDominanceFrontier.h


Index: llvm/include/llvm/Support/GenericIteratedDominanceFrontier.h
===================================================================
--- llvm/include/llvm/Support/GenericIteratedDominanceFrontier.h
+++ llvm/include/llvm/Support/GenericIteratedDominanceFrontier.h
@@ -117,8 +117,7 @@
 
 template <class NodeTy, bool IsPostDom>
 typename ChildrenGetterTy<NodeTy, IsPostDom>::ChildrenTy
-ChildrenGetterTy<NodeTy, IsPostDom>::get(
-    const ChildrenGetterTy<NodeTy, IsPostDom>::NodeRef &N) {
+ChildrenGetterTy<NodeTy, IsPostDom>::get(const NodeRef &N) {
   using OrderedNodeTy =
       typename IDFCalculatorBase<NodeTy, IsPostDom>::OrderedNodeTy;
 
Index: llvm/include/llvm/Analysis/IteratedDominanceFrontier.h
===================================================================
--- llvm/include/llvm/Analysis/IteratedDominanceFrontier.h
+++ llvm/include/llvm/Analysis/IteratedDominanceFrontier.h
@@ -63,8 +63,7 @@
 
 template <bool IsPostDom>
 typename ChildrenGetterTy<BasicBlock, IsPostDom>::ChildrenTy
-ChildrenGetterTy<BasicBlock, IsPostDom>::get(
-    const ChildrenGetterTy<BasicBlock, IsPostDom>::NodeRef &N) {
+ChildrenGetterTy<BasicBlock, IsPostDom>::get(const NodeRef &N) {
 
   using OrderedNodeTy =
       typename IDFCalculatorBase<BasicBlock, IsPostDom>::OrderedNodeTy;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64588.209315.patch
Type: text/x-patch
Size: 1286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190711/117cd486/attachment.bin>


More information about the llvm-commits mailing list