[PATCH] D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 12:14:56 PDT 2019


amyk accepted this revision.
amyk added a comment.

I think this overall looks good. Thanks for extending this to handle the load->shuffle case!



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:5153
       InFlag = Lo.getValue(2);
       VA = RVLocs[++i]; // skip ahead to next loc
       SDValue Hi = DAG.getCopyFromReg(Chain, dl, VA.getLocReg(), MVT::i32,
----------------
Do comments like these need to be full sentences with periods, as well?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63624/new/

https://reviews.llvm.org/D63624





More information about the llvm-commits mailing list