[PATCH] D64033: Add column info for inline sites

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

In D64033#1578894 <https://reviews.llvm.org/D64033#1578894>, @probinson wrote:

> If the change from DW_AT_MIPS_linkage_name to DW_AT_linkage_name made you think the older .o files were MIPS, more likely it is a change in the default DWARF version; older versions of DWARF did not have DW_AT_linkage_name.
>
> I think the .ll tests are sufficient to show we emit the call_column so no need to update the odr-member-functions tests IMO.


Yes, that's what made me think they were MIPS.. thanks for the context. DWARF/ELF is all new to me coming from PDB/COFF/PE world. :) I've reverted the update to that test case, ninja check passed locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64033/new/

https://reviews.llvm.org/D64033