[PATCH] D63750: Dump current PrettyStackTrace on SIGINFO (Ctrl-T)

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 09:25:28 PDT 2019


jordan_rose marked an inline comment as done.
jordan_rose added inline comments.


================
Comment at: include/llvm/Support/PrettyStackTrace.h:38
+  /// \see PrettyStackTraceEntry
+  void EnablePrettyStackTraceOnSigInfoForThisThread(bool ShouldEnable = true);
+
----------------
jordan_rose wrote:
> jfb wrote:
> > I don't understand what `ShouldEnable` means.
> This allows you to turn it back off if you want. Got a better name for the parameter?
I changed the summary comment to "Enables (or disables)". That's probably good enough.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63750/new/

https://reviews.llvm.org/D63750





More information about the llvm-commits mailing list