[PATCH] D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup.

Thu Jul 11 07:15:02 PDT 2019

MaskRay added inline comments.

================
Comment at: test/tools/obj2yaml/invalid-reloc.test:1
+## Check yaml2obj is able to dump a broken relocation
+## that has no symbol associated.
----------------
jhenderson wrote:
> What exactly is broken about the relocation? It's valid for some kinds of relocations to have no symbol.
> 
> I think this test needs renaming and the comment updating.
asan instrumentation may generate `R_*_NONE` for debug info. ld -r may generate `R_*_NONE`. They are used as placeholders when no reasonable relocation is available. In this sense, they are indeed "broken". 

However, here it is probably better to say that a symbol index of 0 can be dumped...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64555/new/

https://reviews.llvm.org/D64555