[PATCH] D64470: [Object/ELF] - Improve error reporting for notes.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/gnu-notes.test:24
 # LLVM-NEXT:   NoteSection {
-# LLVM-NEXT:     Offset: 0x340
+# LLVM-NEXT:     Offset: 0x200
 # LLVM-NEXT:     Size: 0x20
----------------
jhenderson wrote:
> Any particular reason you've changed these Offset values?
I think that is because .text .data .bss are removed so the offset changes.


================
Comment at: test/tools/llvm-readobj/gnu-notes.test:105
+
+# ERR2: error: SHT_NOTE section [index 1] has invalid offset (0x180) or size (4294901760)
+
----------------
jhenderson wrote:
> I don't know what consistency says here, but it was very off-putting to see size listed as decimal, given offset is in hex. I'd prefer both to be hex if possible.
+1 for `Twine::utohexstr(Phdr.p_filesz)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64470/new/

https://reviews.llvm.org/D64470