[PATCH] D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/obj2yaml/invalid-reloc.test:1
+## Check yaml2obj is able to dump a broken relocation
+## that has no symbol associated.
----------------
What exactly is broken about the relocation? It's valid for some kinds of relocations to have no symbol.

I think this test needs renaming and the comment updating.


================
Comment at: test/tools/obj2yaml/section-group.test:43
+      - SectionOrType: .rodata
+  - Name:  .rodata
+    Type:  SHT_PROGBITS
----------------
Nit: too many spaces between tag and value.


================
Comment at: test/tools/obj2yaml/section-group.test:46
+Symbols:
+  - Name:    .rodata
+    Type:    STT_SECTION
----------------
Can you get rid of the two section symbols?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64555/new/

https://reviews.llvm.org/D64555