[PATCH] D64393: [AMDGPU] Fix DPP combiner check for exec modification

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 04:36:38 PDT 2019


vpykhtin added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:6159
+    }
+
     if (I->modifiesRegister(AMDGPU::EXEC, TRI))
----------------
Now I recall why I used the set originally - to detect use instruction fast. Matt, is there other way to detect whether the instruction use a register without scanning its operands?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64393/new/

https://reviews.llvm.org/D64393





More information about the llvm-commits mailing list