[PATCH] D64549: [ELF] Warn rather than error when duplicate version assignments occur

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 02:45:11 PDT 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM, but please wait until someone else take another look too.



================
Comment at: ELF/SymbolTable.cpp:227
+          getName(sym->versionId) + " to " + getName(versionId))
+             .str());
   }
----------------
Seems you can omit the conversion to `.str()`, since `warn` takes `const Twine&`:

```
    warn("attempt to reassign symbol '" + ver.name + "' of " +
          getName(sym->versionId) + " to " + getName(versionId));
```


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64549/new/

https://reviews.llvm.org/D64549





More information about the llvm-commits mailing list