[PATCH] D64472: [llvm-readobj/llvm-readelf] - Report a warning instead of a error when dumping a broken dynamic section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 23:28:38 PDT 2019


grimar added a comment.

In D64472#1577996 <https://reviews.llvm.org/D64472#1577996>, @jhenderson wrote:

> How about a test case that shows that more stuff can be printed after the aborted dynamic printing, perhaps using --all?


Working on that.

> Also, is there a risk that this will print the same warning more than once for the same section, if multiple options are used?

Yes, it might do that. It can be fixed easily, for example `DynRegionInfo` can have a flag saying that region is not valid and so
we then can report a warning only once and set this flag. Though I am not sure this is a problem to report this warning in each place we were
unable to dump something too. I would not expect to see too many places and it makes the output very clear. I.e. it is visible
that there was no information dumped because of a particular error and not something else.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64472/new/

https://reviews.llvm.org/D64472





More information about the llvm-commits mailing list