[PATCH] D64462: [Support] [WIP] Add UpdatableRange class

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 22:35:44 PDT 2019


abrachet updated this revision to Diff 209123.
abrachet added a comment.
Herald added a subscriber: dexonsmith.

Moved files from Support to ADT. Removed base class because it wasn't adding anything. Changed enable_if to specialize on the container type, between AssociativeContainer and SequenceContainer's. Added doxygen comments for all public methods. Added collect() method to return the UpdatableRange as the same type of the original container. Updated unit test to be more comprehensive and use test fixtures. Addressed review comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64462/new/

https://reviews.llvm.org/D64462

Files:
  llvm/include/llvm/ADT/UpdatableRange.h
  llvm/unittests/ADT/CMakeLists.txt
  llvm/unittests/ADT/UpdatableRangeTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64462.209123.patch
Type: text/x-patch
Size: 9020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190711/88b75619/attachment.bin>


More information about the llvm-commits mailing list