[PATCH] D64536: Adding inline comments to code view type records

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h:63
 
-  Error mapInteger(TypeIndex &TypeInd);
+  Error mapInteger(TypeIndex &TypeInd, const char* Comment = nullptr);
 
----------------
Is it possible to change these all to accept `const Twine &Comment = ""`? I think string literals are meant to be implicitly convertible to Twine.

Generally in LLVM StringRef is preferred over const char *. We have some documentation for this here:
https://llvm.org/docs/ProgrammersManual.html#passing-strings-the-stringref-and-twine-classes

I think for this API where the string length is unlikely to be used at all, Twine makes sense, but across LLVM C strings are generally avoided if possible.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64536/new/

https://reviews.llvm.org/D64536