[PATCH] D64427: LLVM Test-Suite: Support Cross-Compilation and Cross-execution targeting arm64-linux-android

Wed Jul 10 13:46:34 PDT 2019

ziangwan marked 6 inline comments as done.
ziangwan added inline comments.

================
Comment at: MultiSource/Benchmarks/CMakeLists.txt:32
 if(NOT "${ARCH}" STREQUAL "XCore")
-  add_subdirectory(7zip)
+  if(NOT TEST_SUITE_REMOTE_CLIENT STREQUAL "adb")
+    add_subdirectory(7zip)
----------------
kristof.beyls wrote:
> I'm wondering if (NOT "${TARGET_OS}" STREQUAL "Android") wouldn't be a better test?
> Isn't the reason many of these programs fail to build that some header file isn't provided on the Android platform?
> Also, that would make the test more similar to other tests already in here that remove specific benchmarks for specific architectures or OSs.
Most of the build failures are due to missing header files in the Android platform. There is an issue with the data format of Microbenchmark. I didn't attempt to fix that since I didn't care much about Microbenchmarks. I simply disabled them. There are a few tests/benchmarks I disabled because of bugs that prevent compilation. I didn't try to fix them either.

================
Comment at: cmake/caches/target-arm64-android-template.sh:1-47
+#!/bin/bash
+rm -r CMakeCache.txt
+
+
+# path to the test-suite source file
+TEST_SUITE_LOCATION="/data/local/tmp/devspace/test-suite"
+# path to android ndk that contains necessary header files and libraries
----------------
kristof.beyls wrote:
> I wonder if you're also aiming to use LNT as an extra layer on top of this test-suite?
> I tend to use LNT to build/run tests/benchmarks. I wonder if support was added in LNT, would there still be a lot of value in having this custom shell script?
> I would love to avoid having to go through different benchmarking flows depending on which OS I'm running benchmarks on.
I currently don't have the plan to add Android-support into LNT. My goal is to run test-suite and SPEC 2006 on Android to obtain data.

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64427/new/

https://reviews.llvm.org/D64427