[PATCH] D63750: Dump current PrettyStackTrace on SIGINFO (Ctrl-T)

[JF Bastien via Phabricator via llvm-commits]

jfb accepted this revision.
jfb added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/Support/PrettyStackTrace.h:38
+  /// \see PrettyStackTraceEntry
+  void EnablePrettyStackTraceOnSigInfoForThisThread(bool ShouldEnable = true);
+
----------------
I don't understand what `ShouldEnable` means.


================
Comment at: lib/Support/PrettyStackTrace.cpp:88
 
 /// PrintCurStackTrace - Print the current stack trace to the specified stream.
+///
----------------
Can you remove the function name from the comment while you're here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63750/new/

https://reviews.llvm.org/D63750