[PATCH] D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/O3-pipeline.ll:36
 ; CHECK-NEXT:       Basic Alias Analysis (stateless AA impl)
-; CHECK-NEXT:         Function Alias Analysis Results
+; CHECK-NEXT:       Function Alias Analysis Results
 ; CHECK-NEXT:       Merge contiguous icmps into a memcmp
----------------
irrelevant


================
Comment at: llvm/test/CodeGen/X86/O3-pipeline.ll:33
 ; CHECK-NEXT:       Basic Alias Analysis (stateless AA impl)
-; CHECK-NEXT:         Function Alias Analysis Results
+; CHECK-NEXT:       Function Alias Analysis Results
 ; CHECK-NEXT:       Merge contiguous icmps into a memcmp
----------------
Please avoid irrelevant changes, commit them in another NFC patch if you would like to change them. 


================
Comment at: llvm/test/CodeGen/X86/O3-pipeline.ll:70
 ; CHECK-NEXT:       X86 PIC Global Base Reg Initialization
-; CHECK-NEXT:        Finalize ISel and expand pseudo-instructions
+; CHECK-NEXT:       Finalize ISel and expand pseudo-instructions
 ; CHECK-NEXT:       X86 Domain Reassignment Pass
----------------
irrelevant


================
Comment at: llvm/test/CodeGen/X86/O3-pipeline.ll:97
 ; CHECK-NEXT:       X86 Optimize Call Frame
-; CHECK-NEXT:       X86 Avoid Store Forwarding Block
+; CHECK-NEXT:       X86 Avoid Store Forwarding Blocks
 ; CHECK-NEXT:       X86 speculative load hardening
----------------
irrelevant changes.


================
Comment at: llvm/test/CodeGen/X86/O3-pipeline.ll:179
 }
+
----------------
extra line? irrelevant


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64394/new/

https://reviews.llvm.org/D64394