[PATCH] D63934: [MIR] Improve PRE condition of MachineCSE optimization

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added a comment.

In D63934#1575308 <https://reviews.llvm.org/D63934#1575308>, @aymanmus wrote:

> Just to make sure I understand the change correctly:
>  This can still hoist instructions outside of their BB and execute them speculatively even if you can't prove that all possible paths execute the instruction, am I right?


Hi @aymanmus, yes, you are right, and this fact is confusing me. You are right -- the speculativeinstruction execution shouldn't be possible after optimization, even if the average performance is growing up. This wasn't intented when I implemented PRE, I'm to take actions for fixing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63934/new/

https://reviews.llvm.org/D63934