[PATCH] D60716: [DwarfDebug] Dump call site debug info into DWARF

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

Thanks a lot for your work with this patch series! It seems very useful.

Sorry for coming with this post-merge question, but I encountered it first now when trying to adapt this to our downstream target; what limitations are imposed on the `MachineOperand` pointer that the `describeLoadedValue` returns? For example, in our downstream target we materialize 0 with a `sub $reg, $reg`, so we'd have to return a pointer to a `MachineOperand` that is not part of the instruction. Is that allowed? I guess x86 has the same issue as it materializes 0 with xor.

Perhaps it would be possible to make the hook return a `MachineOperand` object instead? It could simplify the code a bit in such cases. Or would that be too expensive?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60716/new/

https://reviews.llvm.org/D60716