[PATCH] D64426: [ARM] Adjust how NEON shifts are lowered

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:5681
 
+/// Getvshiftimm - Check if this is a valid build_vector for the immediate
+/// operand of a vector shift operation, where all the elements of the
----------------
Thanks for splitting the patch up. I now actually see that this code was not added, but moved up here from somewhere else.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.h:147
       // Vector shift by immediate:
-      VSHL,         // ...left
-      VSHRs,        // ...right (signed)
-      VSHRu,        // ...right (unsigned)
+      VSHLimm,      // ...left
+      VSHRsimm,     // ...right (signed)
----------------
bikeshedding names: other nodes with an immediate have IMM capatilised. I don't have strong opinions, but more consistent would be to do that here too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64426/new/

https://reviews.llvm.org/D64426