[PATCH] D64231: [FileCheck] Simplify numeric variable interface

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 06:00:22 PDT 2019


thopre added a comment.

In D64231#1573921 <https://reviews.llvm.org/D64231#1573921>, @probinson wrote:

> I was under the impression that an assertion in the public interface of a library API was not a great idea.


Oops my bad, I forgot about that comment. I think only what's in the FileCheck class should be considered public API. The rest ought to be moved to a different header file and is private. FileCheckNumericVariable is an implementation details IMO.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64231/new/

https://reviews.llvm.org/D64231





More information about the llvm-commits mailing list