[llvm] r365621 - [DAGCombine] visitINSERT_SUBVECTOR - use uint64_t subvector index. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 05:21:35 PDT 2019


Author: rksimon
Date: Wed Jul 10 05:21:35 2019
New Revision: 365621

URL: http://llvm.org/viewvc/llvm-project?rev=365621&view=rev
Log:
[DAGCombine] visitINSERT_SUBVECTOR - use uint64_t subvector index. NFCI.

Keep the uint64_t type from getZExtValue() to stop truncation/extension overflow warnings in MSVC in subvector index math.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=365621&r1=365620&r2=365621&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Wed Jul 10 05:21:35 2019
@@ -19272,7 +19272,7 @@ SDValue DAGCombiner::visitINSERT_SUBVECT
   if (!isa<ConstantSDNode>(N2))
     return SDValue();
 
-  unsigned InsIdx = cast<ConstantSDNode>(N2)->getZExtValue();
+  uint64_t InsIdx = cast<ConstantSDNode>(N2)->getZExtValue();
 
   // Push subvector bitcasts to the output, adjusting the index as we go.
   // insert_subvector(bitcast(v), bitcast(s), c1)




More information about the llvm-commits mailing list