[PATCH] D64474: [lld] [NFC] Match new variable names in comments

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 04:27:15 PDT 2019


ruiu added inline comments.


================
Comment at: lld/ELF/DWARF.cpp:62
   static uint64_t resolve(object::RelocationRef ref, uint64_t s,
-                          uint64_t /* A */) {
+                          uint64_t /* a */) {
     return s + ref.getRawDataRefImpl().p;
----------------
Can you simply /**/ so that a becomes a paramter?


================
Comment at: lld/ELF/DWARF.cpp:69
   // For Rel, the addend A is supplied by the caller.
-  static uint64_t resolve(object::RelocationRef /*Ref*/, uint64_t s,
+  static uint64_t resolve(object::RelocationRef /*ref*/, uint64_t s,
                           uint64_t a) {
----------------
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64474/new/

https://reviews.llvm.org/D64474





More information about the llvm-commits mailing list