[PATCH] D64420: [MIPS GlobalISel] Select float and double phi

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 03:13:31 PDT 2019


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: lib/Target/Mips/MipsInstructionSelector.cpp:122
+
+  llvm_unreachable("getRegClassForTypeOnBank can't find register class.\n");
+  return nullptr;
----------------
Is "\n" really necessary here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64420/new/

https://reviews.llvm.org/D64420





More information about the llvm-commits mailing list