[PATCH] D64401: [yaml2obj] - Allow overriding the sh_size field.

Wed Jul 10 03:13:30 PDT 2019

grimar added inline comments.

================
Comment at: test/tools/yaml2obj/elf-override-shsize.yaml:1
+## Check we are able to set custom sh_size field
+## for different sections.
----------------
jhenderson wrote:
> I wonder whether it's worth a test case with both Size and ShSize being set? It would show that the appropriate number of zeroes is written, but the sh_size field is changed. You could show the right number of zeroes are written by having non-zero section data from other sections before and after the broken section.
Done.

================
Comment at: test/tools/yaml2obj/elf-override-shsize.yaml:77
+# RUN: od -t x8 -v %t3 >> %t.txt
+# RUN: FileCheck %s --input-file=%t.txt --check-prefix=CASE2
+
----------------
jhenderson wrote:
> What about a case where the content is smaller than the ShSize?
Done.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64401/new/

https://reviews.llvm.org/D64401