[PATCH] D64473: [Coding style change][lld] Rename variables for non-ELF ports.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/COFF/Chunks.h:102
   // chunk has a back pointer to an output section.
-  void setOutputSectionIdx(uint16_t O) { OSIdx = O; }
-  uint16_t getOutputSectionIdx() const { return OSIdx; }
+  void setOutputSectionIdx(uint16_t o) { oSIdx = o; }
+  uint16_t getOutputSectionIdx() const { return oSIdx; }
----------------
Should it be `osIdx` perhaps?


================
Comment at: lld/COFF/DebugTypes.cpp:263
+  pdb::PDBFile &pDBFile = session->getPDBFile();
+  Expected<pdb::InfoStream &> info = pDBFile.getPDBInfoStream();
   // All PDB Files should have an Info stream.
----------------
`pdbFile`?


================
Comment at: lld/COFF/Driver.h:124
+  void addBuffer(std::unique_ptr<MemoryBuffer> mb, bool wholeArchive);
+  void addArchiveBuffer(MemoryBufferRef mbref, StringRef symName,
+                        StringRef parentName, uint64_t offsetInArchive);
----------------
`mbRef`?


================
Comment at: lld/COFF/InputFiles.cpp:139
+  const coff_section *sec;
+  if (auto ec = cOFFObj->getSection(i, sec))
+    fatal("getSection failed: #" + Twine(i) + ": " + ec.message());
----------------
`coffObj`?


================
Comment at: lld/wasm/SymbolTable.cpp:520
 // then unified later in handleSymbolVariants.
-bool SymbolTable::getFunctionVariant(Symbol* Sym, const WasmSignature *Sig,
-                                     const InputFile *File, Symbol **Out) {
+bool SymbolTable::getFunctionVariant(Symbol* sym, const WasmSignature *sig,
+                                     const InputFile *file, Symbol **out) {
----------------
It looks unformatted. Perhaps you could apply the clang format at the same time?


================
Comment at: lld/wasm/SyntheticSections.h:289
+  SmallVector<std::pair<std::string, std::string>, 8> tools;
+  SmallVector<std::pair<std::string, std::string>, 8> sDKs;
 };
----------------
`sDKs` looks strange. `sdks`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64473/new/

https://reviews.llvm.org/D64473