[PATCH] D63707: [AArch64] Define ETE and TRBE system registers

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 01:47:22 PDT 2019


chill marked an inline comment as done.
chill added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:743
+                     FeaturePostRAScheduler,
+                     FeatureETE
                      ]>;
----------------
ostannard wrote:
> Why are you enabling this for the generic target? No existing hardware will have these instructions, so we should reject them unless they're explicitly enabled.
That's because we have no other means to enable them, thus they are enabled by default.  Our plan is when the future architecture extensions find their place in some future architecture, then to have them enabled for that architecture only. Until then we want to make them available for people to experiment.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63707/new/

https://reviews.llvm.org/D63707





More information about the llvm-commits mailing list