[PATCH] D64045: [InstrProfiling] Put instrumentation into comdat group with function

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 19:46:58 PDT 2019


phosek added a comment.

In D64045#1569136 <https://reviews.llvm.org/D64045#1569136>, @davidxl wrote:

> Do you have a functional test case to show what this patch is trying to accomplish/fix?


What kind of test do you have in mind? You mean and E2E test in LLVM or a real-world use case? The only issue with E2E test is that it's going to require linker to verify that we can indeed GC the unused symbols together with the relevant part of the instrumentation, is that OK?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64045/new/

https://reviews.llvm.org/D64045





More information about the llvm-commits mailing list