[PATCH] D64102: [llvm-lipo] Implement -create part 1

Anusha Basana via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 18:23:08 PDT 2019


anushabasana marked an inline comment as done.
anushabasana added inline comments.


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:357
+  default:
+    return 12;
+  }
----------------
@mtrent The alignment for all of the valid architectures falls under the hard coded segment above. Is it still useful to implement the calculateAlignment function by segments for unknown architecture types?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64102/new/

https://reviews.llvm.org/D64102





More information about the llvm-commits mailing list