[PATCH] D64460: AMDGPU: Add 24-bit mul intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 17:32:07 PDT 2019


arsenm created this revision.
arsenm added a reviewer: rampitec.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.

Insert these during codegenprepare.

This works around a DAG issue where generic combines eliminate the and
asserting the high bits are zero, which then exposes an unknown read
source to the mul combine. It doesn't worth the hassle of trying to
insert an AssertZext or something to try to deal with it.


https://reviews.llvm.org/D64460

Files:
  include/llvm/IR/IntrinsicsAMDGPU.td
  lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
  lib/Target/AMDGPU/SIISelLowering.cpp
  test/CodeGen/AMDGPU/amdgpu-codegenprepare-mul24.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.mul.i24.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.mul.u24.ll
  test/CodeGen/AMDGPU/mad_uint24.ll
  test/CodeGen/AMDGPU/mul.i16.ll
  test/CodeGen/AMDGPU/mul_uint24-amdgcn.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64460.208853.patch
Type: text/x-patch
Size: 37350 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190710/6d266b8a/attachment.bin>


More information about the llvm-commits mailing list