[PATCH] D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In D62455#1576306 <https://reviews.llvm.org/D62455#1576306>, @beanz wrote:

> One thought, we should probably evaluate why those tools are using `add_library` instead of `add_llvm_library`. The right fix might be to move them over. This is exactly the kind of behavior that `add_llvm_library` and `llvm_add_library` were designed to handle.


I agree, however, I remember a lot of churn when these were added, and didn't really follow why they needed to be different, so I was hesitant to make any gratuitous changes.  My goal was just to have nice clean builds on my laptop that didn't take too long or report spurious errors.

I'll take another look and see if I can figure out why they didn't work out of the box.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62455/new/

https://reviews.llvm.org/D62455