[PATCH] D64436: GlobalISel: Combine unmerge of merge with intermediate cast

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 14:42:27 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:298
+      if (ConvertOp) {
+        Builder.setInstr(MI);
+
----------------
aemerson wrote:
> Do we need to restore the builder's insertpt?
The other places here do not. I would assume MI is invalid and the insert point isn't preserved if tryCombineMerges returns true


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64436/new/

https://reviews.llvm.org/D64436





More information about the llvm-commits mailing list