[PATCH] D64033: Add column info for inline sites

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

In D64033#1566445 <https://reviews.llvm.org/D64033#1566445>, @probinson wrote:

> I suspect there are more tests that must or should be updated; grepping for "DW_AT_call_" turns up for example:
>  llvm/test/DebugInfo/NVPTX/debug-info.ll
>  llvm/test/DebugInfo/X86/dbg-value-inlined-parameter.ll
>  llvm/test/tools/dsymutil/odr-member-functions.cpp
>
> and there are a variety of .s files with hand-generated DWARF that probably should be updated as well, under llvm/test/tools/llvm-dwarfdump.


Thanks for taking a look, Paul. You're right that more tests should be updated. I only fixed tests that failed, and I didn't include NVPTX target, so that one was missed. Now I updated all related tests except those hand generated .s under llvm-dwarfdump. I noticed comments saying some of these .s needs manual patching to introduce bad dwarf content for testing error handling, and it wasn't clear from the test  how the manual patch should be done, so it's probably safer to leave it as is (and these tests involving .s input don't really test things related to inline/call sites). Let me know if that's ok..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64033/new/

https://reviews.llvm.org/D64033