[PATCH] D63377: [ORC] Avoid Race in Assertions

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 11:17:47 PDT 2019

Previous message: [PATCH] D64430: [AMDGPU] gfx908 clang target
Next message: [PATCH] D64431: [AMDGPU] gfx908 dot instruction support
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Tentatively LGTM. Was this is generating a TSan error, or a crash? I would expect this to pass TSan, so writing a test case is probably not practical.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63377/new/

https://reviews.llvm.org/D63377

Previous message: [PATCH] D64430: [AMDGPU] gfx908 clang target
Next message: [PATCH] D64431: [AMDGPU] gfx908 dot instruction support
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list