[llvm] r365502 - [ADT] Remove MSVC-only "no two-phase name lookup" typename path.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 08:24:19 PDT 2019


Author: rksimon
Date: Tue Jul  9 08:24:19 2019
New Revision: 365502

URL: http://llvm.org/viewvc/llvm-project?rev=365502&view=rev
Log:
[ADT] Remove MSVC-only "no two-phase name lookup" typename path.

Now that we've dropped VS2015 support (D64326) we can use the regular codepath as VS2017+ correctly handles it


Modified:
    llvm/trunk/unittests/ADT/DenseMapTest.cpp

Modified: llvm/trunk/unittests/ADT/DenseMapTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/DenseMapTest.cpp?rev=365502&r1=365501&r2=365502&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/DenseMapTest.cpp (original)
+++ llvm/trunk/unittests/ADT/DenseMapTest.cpp Tue Jul  9 08:24:19 2019
@@ -119,17 +119,8 @@ TYPED_TEST(DenseMapTest, EmptyIntMapTest
   // Lookup tests
   EXPECT_FALSE(this->Map.count(this->getKey()));
   EXPECT_TRUE(this->Map.find(this->getKey()) == this->Map.end());
-#if !defined(_MSC_VER) || defined(__clang__)
   EXPECT_EQ(typename TypeParam::mapped_type(),
             this->Map.lookup(this->getKey()));
-#else
-  // MSVC, at least old versions, cannot parse the typename to disambiguate
-  // TypeParam::mapped_type as a type. However, because MSVC doesn't implement
-  // two-phase name lookup, it also doesn't require the typename. Deal with
-  // this mutual incompatibility through specialized code.
-  EXPECT_EQ(TypeParam::mapped_type(),
-            this->Map.lookup(this->getKey()));
-#endif
 }
 
 // Constant map tests




More information about the llvm-commits mailing list