[PATCH] D64396: [DWARF] Dump .gdb_index of version 8

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: test/DebugInfo/dwarfdump-dump-gdbindex.test:6
+RUN: cp %p/Inputs/dwarfdump-gdbindex-v7.elf-x86-64 %t
+RUN: %python -c 'with open("%/t", "r+b") as f: f.seek(0x1748); f.write(b"\x08")'
+RUN: llvm-dwarfdump -gdb-index %t | FileCheck --check-prefixes=CHECK,CHECK-V8 %s
----------------
ikudrin wrote:
> Personally, I'd prefer to have another binary file for version 8 than patching the existing one. What do you think?
I think that is not very necessary at the moment. We can do that after the non-empty types CU list issue is fixed or when yaml2obj gets improved to handle .gdb_index


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64396/new/

https://reviews.llvm.org/D64396